micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.88k stars 459 forks source link

Dock not syncs running applications list #293

Open handicraftsman opened 8 years ago

handicraftsman commented 8 years ago

Dock not syncs running applications list (which not in favorites). For example: i am starting Powder Toy (google, if don't know), but it shows on dock only when i am disable and reenable option "Show running applications" (or after some time). Same thing with closing applications.

handicraftsman commented 8 years ago

Ohhh, new info: shell restart fixes this for a while...

micheleg commented 8 years ago

Is it specific to this or some applications? Also, does the problem occurs with the extension disabled in the normal dock inside the overview?

micheleg commented 8 years ago

I forgot to ask: are you running wayland?

handicraftsman commented 8 years ago

Nope, running X. And not tested disabling extension

poxin13 commented 8 years ago

I'm having this same issue with v53 on Ubuntu 16.04/Gnome. Disabling/Enabling show running applications syncs them but you have to do that manually - odd.

micheleg commented 8 years ago

Sorry if I'm tedious about this: Does the problem occurs with the extension disabled, i.e. in the normal dock inside the overview?

poxin13 commented 8 years ago

Well for me, this was fixed on a reboot and seems to be working fine now. Can't speak for @handicraftsman. I made some tweaks before hand but not exactly sure what step may have impacted it.

sketchbuch commented 8 years ago

I have this problem, steam showed up 4 or 5 minutes after the app started and I was able to use it. I have seen this with atom editor too.

Ubutu gnome 16.04 dash to dock in panel mode

franglais125 commented 8 years ago

Maybe adding a signal to _queueRedisplay() might help with this. I remember seeing this issue sporadically, but it went away once I started to use workspace isolation (which connects "restacked").

@sbtypo3 if you see this issue again, can you try just removing* a favorite app? That should trigger a _queueRedisplay(). To be clear, I am not suggesting this as a workaround every time you have this problem, just to know if adding a signal would be helpful at all. If you see that the dash is refreshed properly, then perhaps the _queueRedisplay() thing could be the solution.

*By that I simply mean right clik on a favorite app and select "Remove from Favorites"

I'll try to reproduce the issue (without having workspace isolation activated), and try to see if this works.

sketchbuch commented 8 years ago

it happened again just now. I unfaved another app and steam showed up straight away

franglais125 commented 8 years ago

@sbtypo3 Thanks for the feedback! What version of the (1) extension and (2) Gnome Shell are you using?

sketchbuch commented 8 years ago

3.18.5 (Ubuntu Gnome 16.04) and gnome3 ppa to get latest version of nautilus, but not the staging ppa.

Dash-to-Dock 53

franglais125 commented 8 years ago

@micheleg what do you think of this patch [fbd6079a3fc227c8344dfaeaa23b8a39de4ead17] ?

micheleg commented 8 years ago

You are just moving the signal from one class to the oher, or am I missing something?

franglais125 commented 8 years ago

Yes, but in the docking.js case, it is only connected with workspace isolation. I suspect this is why the problem went away for me (I used to have back then). Moving to dash.js activates it by default.

franglais125 commented 8 years ago

@sbungert there is a new version available. Do you mind updating and checking if the problem is still present?

https://extensions.gnome.org/extension/307/dash-to-dock/

sketchbuch commented 8 years ago

It's sort of half fixed... now when the window for steam appears saying that it is loading and connecting as my user name it appears straight away on the dock, but when that closes and the main steam window opens there is no icon until i open another app or unfav something

franglais125 commented 8 years ago

Thanks.

Here is a branch (with a single commit ahead of v54) with what I hope is a fix: https://github.com/franglais125/dash-to-dock/tree/bugfix_sync

Do you know how to test it?

sketchbuch commented 8 years ago

No... can you give me some tips?

franglais125 commented 8 years ago

Alternatively, you can activate the "Isolate workspaces" option from the Dash-to-dock settings.

Not permanently, but just to see if the problem goes away, i.e. try opening Steam and see if the dock syncs properly when this option is activated.

micheleg commented 8 years ago

Again, can somebody that can reproduce the bug check if it occurs also with the default dock, .i.e. with this extension disabled? I have the feeling it is a problem with the shell. @franglais125's workaround look okish, but I'd rather know why it is required, and if it's the case file an upstream bug,

sketchbuch commented 8 years ago

I just turned it off in the tweak tool and tried steam. The loading window shows up automatically on the dash on overview but the main steam window that appears after signing into steam doesn't

sketchbuch commented 8 years ago

On ubuntugnome 16.10 this problem seems to have been fixed

micheleg commented 8 years ago

@franglais125 The problem with the proposed patch is that the restacked signals is emitted a bit too often to just use it as a workaround, for instance anytime you change window.

franglais125 commented 8 years ago

@micheleg Yes, I generally agree with that. As the other bug you just fixed (issue #386) showed, redisplay() is called way too often. At least for the workspace isolation to work well, the restack signal has worked well, although it does seem a bit excessive at times. I'll try and keep an eye on this and see if I can send improvements from time to time.

As for this issue, it seems that newer versions of the Shell do work better, so maybe over time this particular problem will slowly go away.

micheleg commented 8 years ago

To me it looks like an upstream bug in the appsystem, which maybe has been solved in recent versions.