micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.82k stars 462 forks source link

Popcorntime icon issue #483

Open killown opened 7 years ago

killown commented 7 years ago

I am having an issue with popcorntime icon, I tried a few themes then it's not an icon theme issue screenshot from 2017-04-24 13-47-02

with plank dock it works fine: screenshot from 2017-04-24 13-49-48

micheleg commented 7 years ago

Could you explain further what the issue is? It is not clear to me.

killown commented 7 years ago

hi @micheleg thanks for reply, the dash to dock can't recognize the icon from popcorntime.desktop file then it uses /usr/share/popcorntime/src/app/images/icon.png as default

Django cat /usr/share/applications/popcorntime.desktop [Desktop Entry] Type=Application Name=Popcorn Time Comment=Stream movies and TV shows from torrents Icon=popcorntime TryExec=popcorntime Exec=popcorntime %U MimeType=application/x-bittorrent;x-scheme-handler/magnet; Categories=AudioVideo;Video;Player;Network;FileTransfer;P2P

micheleg commented 7 years ago

What is the behaviour with the extension disabled? Does the icon show up in the default dash (inside the overview)?

killown commented 7 years ago

default dash same issue, show wrong icon, so this bug is from gnome

micheleg commented 7 years ago

This is therefore an upstream bug. Have you tried modifying the desktop to point to the full path of the desired icon?

bilelmoussaoui commented 7 years ago

@killown Electron & Node-Webkit applications needs a StartupWMClass in order to make it possible to assign a correct desktop file to an executable one see more information here https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html You can use xprop WM_CLASS and click on a running instance of popcorn time in order to get the correct WMClass and add StartupWMClass=VALUE with the value the output you've got from xprop which will fix your issue

@micheleg This can be closed:+1:

franglais125 commented 7 years ago

I had to do the same after installing a custom Firefox executable, confirming what @bil-elmoussaoui reports.

fergusincoronato commented 5 years ago

StartupWMClass is only used to group windows with the same class name. You need to look at changing the class with the exec command if the program supports gtk options.

Try running the executable with --class="Popcorn-Time". Worked for me.

See also: · https://askubuntu.com/a/809353/545569 · https://github.com/popcorn-official/popcorn-desktop/issues/305 · https://elementaryos.stackexchange.com/a/16088/10290