michelegargiulo / Witchery-Companion

Other
2 stars 1 forks source link

[Witchery Bug] Infinite loop with Cubic Chunks #36

Open DarianLStephens opened 2 weeks ago

DarianLStephens commented 2 weeks ago

Description Witchery: Resurrected backports the new villager sleeping system. Unfortunately, this seems to want to scan a chunk's worth of a column of blocks. With Cubic Chunks, a column is infinite. I'm not certain how this could be resolved, barring perhaps adding a limit for it to abort or disabling the system altogether? Or make villagers only scan a certain height radius relative to them, if at all possible, to preserve cubic functionality?

When I tried with older versions of WR before this was implemented, all other features seemed to work fine. Waystones would go to and from the extended Y coordinates, altars worked, rituals, it all seemed fine.

Context Environment [X] The issue is present in Single-Player [X] The issue is present in Multi-Player Other mods [ ] The issue is present with just Forge and Witchery: Resurrected [X] The issue is present when the following mods are installed: (please list the minimum amount of mods required to reproduce the issue. The less mods, the quicker the issue can be reproduced and solved) Forge Witchery: Resurrected Cubic Chunks

Steps to Reproduce The more detailed is provided, the easier will be to reproduce and analyze the issue, thus more chances to solve it

  1. Make a world with some Cubic type
  2. Load it
  3. Observe as the game may render for a couple seconds, then hang indefinitely, possibly with an infinite slow climb of RAM usage

Crash Report / logs No crash report, I'm afraid, as the game never actually crashes. I've had it running for upwards of an hour in the state it was, with no recovery or end.

michelegargiulo commented 2 weeks ago

What version of Forge and Cubic Chunks are you using? I can't even get into a world due to a crash with only forge and CC

DarianLStephens commented 2 weeks ago

CubicChunks-1.12.2-0.0.1208.0, Forge 14.23.5.2860