check if tenant has i18n config

micheleriva / krabs

🦀 Express.js/Fastify middleware and virtual host for multi-tenant Next.js applications

https://krabs.vercel.app

MIT License

363 stars 28 forks source link

check if tenant has i18n config #33

Closed ameenaburayya closed 2 years ago

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/micheleriva/krabs/AFgs4ntLFCH83ESy7y8FFBLBp2SB
✅ Preview: https://krabs-git-fork-ameenaburayya-add-nextjs-i18n-0dbd82-micheleriva.vercel.app

micheleriva commented 2 years ago

Hi @ameenaburayya , thanks for this PR, it's super!

I'm reviewing it right now and I'll give you a feedback ASAP.

Thanks again!

micheleriva commented 2 years ago

@ameenaburayya I did a small review and noticed the following points:

It seems fine on Express.js, but we should support Fastify too (it's good you made a utility function for most of your edits so that we can reuse them on Fastify)
I'd love to see some unit and e2e tests

thanks again for your PR!