michelesalvador / FamilyGem

Android app for genealogical trees
https://www.familygem.app
GNU General Public License v3.0
114 stars 32 forks source link

Age limit and fixed date #102

Closed PC-Smith closed 7 months ago

PC-Smith commented 8 months ago

It's possible disable age limit (show persons with 500 yo if not marked as dead) or set a fixed date (fix 2000 and person born in 1990 will always shown 10 yo)?

michelesalvador commented 8 months ago

At the moment the age limit is hard-coded as 120 (years) in:

  1. Birthday notifications
  2. Person's dates detail displayed all across the app
  3. Age calculated to sort people in Persons list

When the age exceedes this limit, a person is not marked as dead (black ribbon). The black ribbon appears only when a person has a Death or Burial event.

Anyway, I agree to add a setting to modify this years age limit. I would put it at app-level, not at tree or person-level. It could not be completely disabled, but it could be set up to 999999999 years.

However, I don't understand the "fixed date" question. Maybe you want to add a Death event common for all the persons of a tree (e.g. a cataclysm)?

PC-Smith commented 8 months ago

Firstly, I would like to thank you from the bottom of my heart for considering adjusting the age limit shown. Second, the "fixed date" would be a configuration to place a specific date to be considered in the age calculation, which currently considers the date in the cell phone configuration, I imagine.

For example, I set the date to "May the 4th, 2000", so, if a person was born in 1980, the display age will be 20 yo instead of 43 yo. Family Echo, the site I used before migrating to FamilyGem, has a configuration like this.

michelesalvador commented 7 months ago

With commit 007fd58 I have added a brand new tree settings activity, where the user can set:

aaannndddyyy commented 7 months ago

Sorry if the question is stupid, but what would a use case for this be ? Why would I set the date to May 4, 2000 when we're in the year 2023? .asking because I'm curious and maybe it's something useful that I haven't yet considered myself and would use once I know about it

PC-Smith commented 7 months ago

Sorry if the question is stupid, but what would a use case for this be ? Why would I set the date to May 4, 2000 when we're in the year 2023? .asking because I'm curious and maybe it's something useful that I haven't yet considered myself not would use once I know about it

It can be used to easily calculate the age of multiple people in a given year. For example, how old each of your uncles was when your father was born. Another use is for fictional characters whose story takes place in a specific year.

PC-Smith commented 7 months ago

With commit 007fd58 I have added a brand new tree settings activity, where the user can set:

  • Maximum life span
  • Custom date to calculate age

Thank you for considering the suggestion. 😊👍🏻

aaannndddyyy commented 7 months ago

With commit 007fd58 I have added a brand new tree settings activity, where the user can set:

  • Maximum life span
  • Custom date to calculate age

Thank you for considering the suggestion. 😊👍🏻

Can this ticket be closed then?

PC-Smith commented 7 months ago

Yes. Can you do it or do I have to do it? I'm new to Github, I don't really know how things work here.

Em sáb, 2 de dez de 2023 15:07, aaannndddyyy @.***> escreveu:

With commit 007fd58 https://github.com/michelesalvador/FamilyGem/commit/007fd58a0e9d629750daab0feeb81aff526cd05b I have added a brand new tree settings activity, where the user can set:

  • Maximum life span
  • Custom date to calculate age

Thank you for considering the suggestion. 😊👍🏻

Can this ticket be closed then?

— Reply to this email directly, view it on GitHub https://github.com/michelesalvador/FamilyGem/issues/102#issuecomment-1837218525, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDUEDIGQSMB7KOSPHWKZG2LYHNU73AVCNFSM6AAAAAA6WXIK7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGIYTQNJSGU . You are receiving this because you authored the thread.Message ID: @.***>

aaannndddyyy commented 7 months ago

Eu não posso. Só você ou Michele. Aqui em baixo no mesmo github, onde vc pode escrever, está ao lado a opção close ticket. Através de email não sei se é possível