search

michelesalvador / FamilyGem

Android app for genealogical trees
https://www.familygem.app
GNU General Public License v3.0
125 stars 34 forks source link

Add monochrome icon #103

Closed apiote closed 10 months ago

apiote commented 10 months ago

This adds a themed icon for launchers in Android >= 13 (https://developer.android.com/develop/ui/views/launch/icon_design_adaptive)

michelesalvador commented 10 months ago

Thank you for your pull request! I don't have a physical device with Android >= 13: so I tested on the emulators. As I can see to obtain a themed icon there is no need to create a new _icon_foregroundmono.xml drawable. The only needed line in icon.xml is:

<monochrome android:drawable="@drawable/icon_foreground" />

So reusing the already existing _iconforeground.xml.

Do you agree?

apiote commented 10 months ago

Indeed. I checked when there's no additional drawable and the monochrome line uses the existing icon_foreground and it works at my end. I updated the PR — deleted the unnecessary drawable and changed icon.xml

michelesalvador commented 10 months ago

Perfect. Thank you!