michelesalvador / FamilyGem

Android app for genealogical trees
https://www.familygem.app
GNU General Public License v3.0
114 stars 32 forks source link

Missing comma #111

Open aaannndddyyy opened 7 months ago

aaannndddyyy commented 7 months ago

If I add an address with city and state, then in the profile, there should be a comma between city /town and state, just like there is one between state and country. And if I don't add a state, there is a space instead of a simple omission. That has the effect that there's a space in front of the comma where no space is supposed to be.

michelesalvador commented 4 months ago

there should be a comma between city/town and state

I suppose that depends on the cultural flavor of writing an address. For example I like my address written like this:

Via Occioni 19, 31015 Conegliano TV, Italy
       ↑          ↑       ↑       ↑    ↑
     Line 1     Postal   City   Prov Country

I wouldn't like an extra comma between City and Province.

Maybe you are used to write the State/province extended (Nordrhein-Westfalen) rather than abbreviated (NW)?

And if I don't add a state, there is a space instead of a simple omission.

Yes, this is a flaw. Just fixed.

aaannndddyyy commented 4 months ago

In the US, you write "New York, New York" or "Springfield, Colorado" , "Palm Springs, CA" "Palm Springs California" looks odd, as it suggests it were one name, but in fact , the name is jist "Palm Springs" , the state is a different thing, as is the country. Same in German: "Hamm, NRW" or "Hamm, Nordrhein-Westfalen". An address "Feodor-Lynen-Straße 25, 81377 München, Bayern, Deutschland"