michelesalvador / FamilyGem

Android app for genealogical trees
https://www.familygem.app
GNU General Public License v3.0
130 stars 34 forks source link

Minor string issue in Trees display #89

Closed jer194 closed 9 months ago

jer194 commented 1 year ago

In the 'Trees' display, in German language, the display looks like: "xxx personen - 3 generationen - 3 medien", whereas it should read: "xxx Personen - 3 Generationen - 3 Medien".

Of course that's a minor issue, but still looks a bit ugly.

The problem seems to be here (not in 'res'):

grep Lower app/src/main/java/app/familygem/TreesActivity.java contesto.getString(alb.persons == 1 ? R.string.person : R.string.persons).toLowerCase(); contesto.getString(alb.generations == 1 ? R.string.generation : R.string.generations).toLowerCase(); dati += " - " + alb.media + " " + contesto.getString(R.string.media).toLowerCase();

Looks like 'toLowerCase()' should not be applied here ...

The same is true for all the menu items, eg when selecting 'Personen' from the menu, I'm getting 'xxx personen' in the headline of the 'persons' display, instead of 'xxx Personen'.

Fix: disable 'toLower' here:

Similar: when trying to add persons:

michelesalvador commented 11 months ago

I agree. This is a know issue for German, and maybe other languages, but not for the majority, where lowercase is correct. Quite easy to fix: toLowerCase() should be applied only if default language is not German.

I'll fix it.

michelesalvador commented 9 months ago

Fixed with 4791420 and available from version 1.0.1.