search

michelesalvador / FamilyGem

Android app for genealogical trees
https://www.familygem.app
GNU General Public License v3.0
125 stars 34 forks source link

add duplicate checks #99

Open otto22otto opened 1 year ago

otto22otto commented 1 year ago

I noticed that you get no warning (or error) with duplicates. Sure it's not easy to define when two IDs probably describe the same person. Perhaps if >70% of the most relevant non-empty tags (names, birth/death date, father, mother, siblings, children) matches? I ran into this e.g. by adding a sibling into the wrong family. So after trying to correct this I got a sister which had itself (of cause a duplicate) as a sister.

michelesalvador commented 10 months ago

You are right. It's not easy to define two persons the same considering names, events, relations etc.

Where would you put this check for duplicate persons? Every time you add a person? Or inside the Find errors function?

otto22otto commented 10 months ago

glad to see you are still engaged in the app. I personally would put it with the error checking but only as a warning. I expect most incidents will be with "NN" dummies or incomplete filled IDs. So to be handled when you do a cleanup or enhancement of the family tree. Just another idea for a handy check: count unconnected trees within a file.

michelesalvador commented 7 months ago

I personally would put it with the error checking but only as a warning.

At the moment Find errors examines only "technical" problems that need to be definitely fixed. We should introduce the concept of "warning". And you are right, often there are several identical "NN" dummies that represent different persons.

Interesting also the idea of counting unconnected trees. Similar to Persons → Sort by → Number of relatives, that finds unconnected persons. Not so easy to implement, but could be useful.