michelf / php-markdown

Parser for Markdown and Markdown Extra derived from the original Markdown.pl by John Gruber.
http://michelf.ca/projects/php-markdown/
Other
3.42k stars 530 forks source link

Custom attributes with quotes? #367

Open jerry1970 opened 2 years ago

jerry1970 commented 2 years ago

Currently the extra attributes cannot take a quotes string. So {attr1=abc attr2="def ghi"} does not work.

The source regex is this:

protected $id_class_attr_catch_re = '\{((?>[ ]*[#.a-z][-_:a-zA-Z0-9=]+){1,})[ ]*\}';

Is there a reason why quoted attributes are not possible?

I am going to see if I can change this to make it work in a derived class, if this is not on the list yet.

Question: the {1,}, is there a reason why this is not +?

Thanks!

michelf commented 2 years ago

I don't think there is any particular reason it's not supported. Feel free to work on this, it'd be a good addition.

I don't think there is any particular reason for {1,}instead of +. You can change it if you want.