Fix PHPStan issues and build on PHP 8.2

michelf / php-markdown

Parser for Markdown and Markdown Extra derived from the original Markdown.pl by John Gruber.

http://michelf.ca/projects/php-markdown/

Other

3.42k stars 530 forks source link

Fix PHPStan issues and build on PHP 8.2 #368

Closed sanmai closed 2 years ago

sanmai commented 2 years ago

Looks like PHPStan is kinda lost here.

michelf commented 2 years ago

I see you're hitting some problems with the PHPStan and the tests. I think it's confused by the implicit treatment of DOMNode as DOMText (and perhaps other similar things). I tried to fix it in #377, but ended up fixing the wrong things and abandoned because I had not time left for this.

Thank you for your work.

sanmai commented 2 years ago

@michelf Thanks for considering this PR! Please let me know if you need anything else or something isn't clear. Hopefully you can squash-merge this mess of commits.

sanmai commented 2 years ago

Build is passing :tada: