Closed iwill closed 1 year ago
I see in the logs:
Undefined offset: 4
/home/runner/work/php-markdown/php-markdown/Michelf/MarkdownExtra.php:1199
It seems the error comes from a notice about $matches[4]
when there is a table with no extra attribute block. I suggest you use the null coalescing operator ($matches[4] ?? null
) to handle more cleanly cases where the regular expression finds no extra attribute block and there is no $matches[4]
.
@michelf Hi, I fixed the unit test error, would you like to merge this PR?
@iwill Looks good. Sorry about it taking so long. I think GitHub never notified me about you pushing more changes.
Add id and class attr for table in Markdown:
HTML: