michelgrootjans / explaining-flow

Creative Commons Attribution Share Alike 4.0 International
106 stars 15 forks source link

Enter multiple specific worker skills from the UI #22

Closed immortaleeb closed 2 years ago

immortaleeb commented 2 years ago

This adds the ability to assign multiple, specific skills to workers from the UI. Skills are separated by a +.

E.g.: dev, dev+qa would create two workers:

To achieve this, I extracted a parsing.js module from setup.js which only contains parsing methods that work on primitives (i.e. no document.querySelector() stuff). I also took the liberty to write some tests for those methods (see parsing.spec.js).

Lastly, I changed the format of the data passed to a scenario (also see changes in scenario.spec.js):

Let me know if this is useful or if you see anything that can be improved :)

michelgrootjans commented 2 years ago

Thank you for your help.

I really like how you solved this challenge. Good understandable tests too.