Dragon Ball Z The Legacy of Goku - Incorrect colors

michelhe / rustboyadvance-ng

RustBoyAdvance-NG is a Nintendo™ Game Boy Advance emulator and debugger, written in the rust programming language.

MIT License

596 stars 23 forks source link

Dragon Ball Z The Legacy of Goku - Incorrect colors #99

Closed xTibor closed 4 years ago

xTibor commented 4 years ago

Screenshot_20200522_102436

This title text should be black, not magenta. Something is mishandled around transparency/background palette #0 here.

michelhe commented 4 years ago

Very similar to what happens to Goku's hair in Dragon Ball Z - Supersonic Warriors

xTibor commented 4 years ago

https://github.com/michelhe/rustboyadvance-ng/blob/965d4aaae0367be9a7b338fb43cc5cbd07dc5e3b/rustboyadvance-core/src/gpu/rgb15.rs#L18

The magic value chosen for transparent colors is the issue. Games sometimes set the high unused color bit for reasons. In this case Goku's hair is colored 0x8000, clashing with that transparent constant.

michelhe commented 4 years ago

Thanks!