michellab / Sire

Sire Molecular Simulations Framework
http://siremol.org
GNU General Public License v3.0
95 stars 26 forks source link

Switching to conda-forge OpenMM #334

Closed lohedges closed 2 years ago

lohedges commented 3 years ago

OpenMM is now available through https://anaconda.org/conda-forge/openmm. I was hoping to remove the omnia channel dependency but there appear to be a couple of issues:

chryswoods commented 3 years ago

That is really annoying. I think you may need to raise an issue with OpenMM asking why they have bundled cudatoolkit. An extra 1 GB download is a lot. If they have a good reason then we are stuck with that as this would become the main and supported version. There aren't any good solutions - if we bundle then our installer is too large. If we don't bundle and install later, then we open up to a whole range of support issues if there an incompatibilities introduced by re-running conda install.

You should also ask about the lack of labels. optimise_openmm was needed because OpenMM didn't work optimally on all computers. If they have solved this problem then we wouldn't need optimise_openmm. I'd be reticent to push people to the omnia channel if we've jumped to conda-forge as this will cause support headaches in the future, especially as we see higher adoption of python 3.8 and 3.9.

lohedges commented 3 years ago

Yes, it's a pain, but seems to be the conda way. It would be nice if they had another version of the package which didn't bundle the CUDA ToolKit, since you don't require it to use OpenMM unless you want to run on a GPU, and then you might have a pretty custom setup.

With regards to the labels: Perhaps there's no need for the them anymore, i.e. you might be able to specify a version of the toolkit which would automatically pin the required version of OpenMM, e.g.

conda install -c conda-forge openmm cudatoolkit=10
lohedges commented 2 years ago

Closing since we now build on top of conda-forge OpenMM.