michellab / Sire

Sire Molecular Simulations Framework
http://siremol.org
GNU General Public License v3.0
95 stars 26 forks source link

Fixed the sending of analytics data (broken since November 2020) #343

Closed chryswoods closed 3 years ago

chryswoods commented 3 years ago

Fixed the issue that analytics from Sire stopped after November 2020.

This was because the analytics were being sent via HTTP and the website was sending back a permanent redirect from that date, meaning that the data wasn't collected.

The fix is to switch to HTTPS. This is also safer as it stops sending potentially sensitive tracking data in plain text.

lohedges commented 3 years ago

Fantastic. I had visited the analytics page recently and had wondered why everything looked so funky. I also forgot to mention this to you!

Everything looks good to me. I'm happy to merge.

chryswoods commented 3 years ago

Thanks - quite a pain to track down as I thought it was a php error initially (I'd upgraded php). The analytics are definitely something I'd like to rewrite and improve "one day" ;-)