michellab / Sire

Sire Molecular Simulations Framework
http://siremol.org
GNU General Public License v3.0
95 stars 26 forks source link

Correct Writing of Steps to simfile.dat #399

Closed fjclark closed 2 years ago

fjclark commented 2 years ago

Hello,

Currently, the step number written to simfile.dat seems to be too low by energy_frequency. This results in a final step number energy_frequency lower than expected, and an initial step number of zero, despite no data being stored until after the first energy_frequency steps. I've offset the steps written by simfile.dat by energy_frequency to account for this.

Thanks, Finlay

chryswoods commented 2 years ago

This looks sensible to me :-)

I'll leave it to @jmichel80 to merge, as it affects the OpenMM code.