Add print formatting for a poem

michelmansour / virgil

A delightful way to share, discuss, and annotate poetry

MIT License

2 stars 2 forks source link

Add print formatting for a poem #11

Closed drewrey closed 8 years ago

drewrey commented 8 years ago

Center the title and byline by targeting the .poemTitle class and the p tag, respectively.
Handle multiple pages by setting .poem class's position property to absolute.
Specify a serif font for printing.
Set line-height larger than font-size to make physical annotations easier.

Tested on:

Firefox 48
Safari 9
Chrome 52

Each browser has a browser-specific print style wrt page title, page url, date, etc, but the above functionality is maintained in each.

michelmansour commented 8 years ago

It seems to be printing two pages (the second one blank) in Firefox and Chrome on Mac. Looks fine in Safari and Firefox on Linux.

michelmansour commented 8 years ago

Apparently between my first test on Linux and my subsequent tests seconds later on Mac, you managed to force-push an update to this branch. Now I'm getting the two-page printout on Linux (Firefox) as well.

drewrey commented 8 years ago

Hm, I didn't force-push in the meantime, but I am seeing those issues on Mac.

drewrey commented 8 years ago

Ah, found a solution for the blank page by setting height: auto.

~~I'll work now on making the byline a first-class citizen.~~ Done.