search

michelmansour / virgil

A delightful way to share, discuss, and annotate poetry
MIT License
2 stars 2 forks source link

Add ability to add comments to a poem #6

Closed drewrey closed 8 years ago

drewrey commented 8 years ago
drewrey commented 8 years ago

I'm seeing some weirdness in the master branch. When adding a poem, id is a number; however, when reordering the poem list, poems.json saves id as a string. At the moment, I'm not sure why this is. This behavior is also present on this branch.

On this branch, after re-ordering the poems, this bug is causing some warnings in the browser about failed prop types.

michelmansour commented 8 years ago

This looks good, except for the couple of small things I pointed out. But I want to wait until the poem POST bugs are resolved in #7 before merging.

michelmansour commented 8 years ago

7 is merged, so as soon as comments (ha-ha) are addressed, and this branch is rebased on master, we should be good to merge.

drewrey commented 8 years ago

Pushed a commit to address your comments, @michelmansour.

drewrey commented 8 years ago

Pushed changes to encode poemId in the url prop for CommentBox.