search

michelp / pgsodium

Modern cryptography for PostgreSQL using libsodium.
Other
546 stars 32 forks source link

Add support for a HashiCorp Vault getkey script #32

Closed apg closed 1 year ago

apg commented 2 years ago

Hi!

Was reading some stuff about Supabase Vault and wondered how to use HashiCorp Vault for the key, so decided to take a crack at something basic, inspired by the other getkey scripts.

Like the other getkey scripts, it hopes to find some environment variables, pertaining to Vault, and of course, uses env vars for the regular configuration.

ioguix commented 1 year ago

Hi there,

Is there any reason this PR has been closed? Is it because of pgsodium_getkey_doppler.sh? I suppose the branch just need to be rebased/merge?

Providing the getkey script for Vault seems interesting.

apg commented 1 year ago

If it was because I didn’t respond to comments: sorry. I’ve been busy. I can pick this up next week. How would you like to proceed?

michelp commented 1 year ago

Hmm I didn't mean to close it if I did, it coincides with me migrating from master to main, could it be an automatic GH action when a branch is deleted?

No worries, if you don't mind reopening another I'll merge it when the comments are resolved. I'll also add you and @ioguix as collaborators so you can also review/merge.

(Ah, the button won't let me "Reopen and comment" the tool-tip says "The master branch has been deleted" so yeah, it likely got closed automatically).