search

michelsalib / BCCResqueBundle

The BCC resque bundle provides integration of php-resque to Symfony2. It is inspired from resque, a Redis-backed Ruby library for creating background jobs, placing them on multiple queues, and processing them later.
122 stars 91 forks source link

stop worker all #63

Open lightglitch opened 10 years ago

lightglitch commented 10 years ago

When you stop all workers executing 

bcc:resque:worker-stop --all

you should filter and only kill the ones on the machine where the script is executed. Because now you can send kill to others services.

I will try to do a pull request ...

lightglitch commented 10 years ago

It's possible to create a branch based on 1.1.7 so that I can create the pull request for the 1.1.8 version?

mrbase commented 10 years ago

as i see it you should make a pull request against the master branch - we should then decide if not the master branch is stable enough to tag the next version aka. 1.1.8

lightglitch commented 10 years ago

I just though that the master was going to be 1.2 or something because of the upgrade of the dependencies:

https://github.com/michelsalib/BCCResqueBundle/commit/8a097a7985a8a2cc9b7fab2448e4d416132092dc https://github.com/michelsalib/BCCResqueBundle/commit/26532ed06d5acfe29a868fc1061c6341c8264b23

I don't think that a maintenance release should have the external libraries upgraded like that because of breaking changes, but that's my opinion I leave the decision to you.

If that is your decision I need to be careful when upgrading from 1.1.7 to 1.1.8 to not break my code.

I will make the pull to master, then.

mrbase commented 10 years ago

ahm, that seams fair .. guess we have to address versioning in general