search

michelsalib / Gi7

A github app for Windows Phone 7
31 stars 14 forks source link

Simplifying the home view #71

Open codewithtyler opened 9 years ago

codewithtyler commented 9 years ago

After our discussion on #63, I found my old Android phone and installed the official GitHub application. I noticed that the GitHub team only placed four tabs, or in our case pivots, on the main view. They have:

  1. news
  2. repositories (watched and owned)
  3. followers
  4. following

What does everyone think about condensing our number of pivots to just those four plus the search? Keep in mind this is when you first open the app not when viewing a repository. It would definitely simplify the view for the user and I could have the profile view moved to BindableApplicationBar with the About and the Logout options. This would also be a good location for the refresh button. Opinions?

NPadrutt commented 9 years ago

Sounds reasonable to me.

michelsalib commented 9 years ago

:+1:

codewithtyler commented 9 years ago

I've almost got this fully implemented. I've got everything down to the four pivots plus the search pivot. I've also moved the profile to the BindableApplicationBar; however, I do have a couple bugs I can't seem to get worked out.

First, the repositories pivot is only showing the owned repositories. I'm assuming this is partly due to the client being originally set up as making two separate requests, one for owned repos and one for watched repos. If that's the cause then something will need to be done in order to get a combined list.

Second, the button for the profile I've got set up just like the log out button. That way when the user logs in the button should be enabled. Unfortunately the log out button is getting enabled but not the profile button, and I'm not sure why.

Any suggestions on why this might be?

NPadrutt commented 9 years ago

Why not keep the 2 lists but among themselves and then get the data with the two requests?

Can it have something to do with some kind of NotifyPropertyChanged issue?

NPadrutt commented 9 years ago

Just had a look at your menu item in the bindable appbar. I guess you should try it the way of the logout button. It isn't bound directly to the IsLoggedIn but goes via the CanExecute. This is changed in the setter of the IsLoggedIn via logoutCommand.RaiseCanExecuteChanged();

codewithtyler commented 9 years ago

Even when I bind it directly to IsLoggedIn it still does the same thing.

NPadrutt commented 9 years ago

And if you try it via tha RaiseCanExecuteChanged?

codewithtyler commented 9 years ago

Same result.