search

michelsalib / Gi7

A github app for Windows Phone 7
31 stars 14 forks source link

Use octokit? #74

Open NPadrutt opened 9 years ago

NPadrutt commented 9 years ago

I just found this library:

https://github.com/octokit/octokit.net

It seems it provides an implementation for a lot who we also need. Therefore it sounds like a good idea to use the library and share development here. Or would this be a too massive change?

codewithtyler commented 9 years ago

It mentions Windows 8 but not Windows Phone. If we did decide to go with something like this we would definitely need to test it first to make sure it's compatible.

NPadrutt commented 9 years ago

sure. I saw in the Issue list that there are already windows phone apps out there who are using it. For example: http://www.windowsphone.com/de-de/store/app/octocentral/5450b4ca-875b-4d47-8d2a-75004a873f87 (Although this seems to be a WP8.1 Store App and not a 8.1 Silverlight App, but maybe this would also be a consideration).

AlbertoMonteiro commented 9 years ago

octokit os mantained by The github team, we could test it, I guess that the github windows app use it.

NPadrutt commented 9 years ago

I made a quick test. At least adding works without any problems.

codewithtyler commented 9 years ago

I think it would definitely simplify the project in the long run. The problem I see with using it is there would be a good bit that would need to be changed since this would most likely remove the need for RestSharp.

NPadrutt commented 9 years ago

I think there should be transition time while the existing things can use the existing code and new things can use octokit. But your certainly right that this would mean bigger changes to the project. But IMHO it's worth it.

codewithtyler commented 9 years ago

I think it's definitely worth the time. If we are going to do this, then we should probably make a list of what changes we would want to implement first using Octokit.

AlbertoMonteiro commented 9 years ago

Agree with @RandomlyKnighted

NPadrutt commented 9 years ago

Agreed. We could make "refactor with octokit"-issues. Or a wikipage.

codewithtyler commented 9 years ago

Why not both? The wiki could also be used for notes that we find on the Octokit project.

NPadrutt commented 9 years ago

good point.

codewithtyler commented 9 years ago

I added a "Refactor-With-Ocotokit" label.

@michelsalib can you add a wiki to the project please?

AlbertoMonteiro commented 9 years ago

When fixing some issue, I used Octokit, I really love it, much better than use RestSharp!!! :octocat: Octokit use TPL(async,await) FTW!!!!

NPadrutt commented 9 years ago

Yeah it's really nice to use :)

AlbertoMonteiro commented 9 years ago

I think we should split views for each developer and refactor everything with Octokit. Since a lot things isn't working properly.

NPadrutt commented 9 years ago

split views for each developer? you mean that everyone takes responsibilty for refactoring some views?

I agree that we have to refactor everything or nearly everything with octokit. The wikipage would be nice to organize it. But for that we need @michelsalib and it seems he isn't very active atm.

AlbertoMonteiro commented 9 years ago

Yeah, everyone take some view and do the job. About @michelsalib we could change the main repository to be some of us that are active. What do you think?

NPadrutt commented 9 years ago

yeah I tend to something like that. I think we should that discuss that in skype. Maybe a bit easier than with comments here

AlbertoMonteiro commented 9 years ago

I'm eating now when I back to work we can talk if you are available.

NPadrutt commented 9 years ago

Enjoy your meal. I will be available although only for chat I guess.

michelsalib commented 9 years ago

Hey guys, thanks for working on this. I don't really mind moving the repo. Though if we only need to activate the wiki I can gladly do it :)

michelsalib commented 9 years ago

Wiki is on!