search

michelsalib / Gi7

A github app for Windows Phone 7
31 stars 14 forks source link

Merging of Pull Requests #76

Open NPadrutt opened 9 years ago

NPadrutt commented 9 years ago

How do you guys plan to handle the stuff with the pull request? Everyone merges his own pull requests as soon as he think it's done, a single person who checkes all pull request or something like each pull request is be merged by someone other than the creator?

codewithtyler commented 9 years ago

That's a good question, we should definitely be consistent. I think each pull request should be merged by someone other than the creator that way everything can be reviewed before being merged (in order to help catch potential problems).

NPadrutt commented 9 years ago

This is my favorite option as well.

@AlbertoMonteiro @michelsalib what do you mean?

AlbertoMonteiro commented 9 years ago

I agree, and we should write tests to have more guarantee when writing new code and doesn't break existent one.

codewithtyler commented 9 years ago

Is anyone good at writing tests? I know I could still use some practice at it.

NPadrutt commented 9 years ago

Well, I can write tests. But I wouldn't call me an expert. But let's make an own issue for the unit tests discussion.

To come back to the topic here: pull request have to be merged by someone other than the creator -> all fine with that?

codewithtyler commented 9 years ago

Sounds good!

AlbertoMonteiro commented 9 years ago

Ok for me