Profile pictures are now showing properly

michelsalib / Gi7

A github app for Windows Phone 7

31 stars 14 forks source link

Closed AlbertoMonteiro closed 9 years ago

AlbertoMonteiro commented 9 years ago

Profile pictures are now showing properly Resolve #58

codewithtyler commented 9 years ago

What was the reason they were not showing up properly?

AlbertoMonteiro commented 9 years ago

@RandomlyKnighted On https://github.com/AlbertoMonteiro/Gi7/blob/master/Gi7.Client/Model/User.cs#L46 the GravatarId was being setted as empty and that override the right url in AvatarUrl, so I just checked if GravatarId is not empty before change AvatarUrl. You can check in this commit: https://github.com/AlbertoMonteiro/Gi7/commit/7f0f007c7ad4f3a1b4ffd869cad199aab5d6ba11

Btw, are you going to test this pr?