search

michelson / dante2

A complete rewrite of dante editor in draft-js
https://michelson.github.io/dante2/
Other
912 stars 122 forks source link

The futur of dante2 #70

Closed BafS closed 6 years ago

BafS commented 7 years ago

Hi,

First of all, I want to thank you for this project, I think it's probably the best medium-like editor with Draftjs. In the other hand, the project seems not really active and I wanted to know if you have plans to upgrade dante2 to React 16 and the last version of Draftjs (a lot of depreciations need to be updated for that).

Thanks in advance !

michelson commented 7 years ago

Hi! I've updated the dependencies on Dante2, I've seen that is working fine , could you point out where are the deprecation warnings ?

BafS commented 7 years ago

With React 16 and Draft 0.10.3 I have those kind of warnings

WARNING: DraftEntity.mergeData will be deprecated soon!
Please use "contentState.mergeEntityData" instead.

WARNING: DraftEntity.get will be deprecated soon!
Please use "contentState.getEntity" instead.
michelson commented 7 years ago

Thanks @BafS , do you see those deprecation warnings when compile project with yarn start ? or yarn build ?

BafS commented 7 years ago

With yarn start. It appear with Draft 0.10.

michelson commented 7 years ago

are you trying my pull request at #71 ? , because I don't see any deprecation warning, well , in fact i'm seen only one deprecation in the webpack.

Project is running at http://localhost:8081/
webpack output is served from /
(node:24577) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Hash: 00a263806a35a94a54ef
Version: webpack 2.7.0
Time: 7561ms
                       Asset       Size  Chunks                    Chunk Names
                      app.js     106 kB       1  [emitted]         app
images/dante-editor-logo.png    1.61 kB          [emitted]
             fonts/dante.eot    2.05 kB          [emitted]
          fonts/fontello.eot    12.6 kB          [emitted]
             fonts/dante.svg    3.34 kB          [emitted]
             fonts/dante.ttf    1.88 kB          [emitted]
            fonts/dante.woff    1.96 kB          [emitted]
          fonts/fontello.svg    13.6 kB          [emitted]
          fonts/fontello.ttf    12.4 kB          [emitted]
         fonts/fontello.woff    6.86 kB          [emitted]
                    dante.js    97.6 kB       0  [emitted]         dante
      images/github-logo.png    3.47 kB          [emitted]
            dante-vendors.js    1.33 MB       2  [emitted]  [big]  dante-vendors
                     app.css    8.04 kB       1  [emitted]         app
                   dante.css    38.1 kB       0  [emitted]         dante
                dante.js.map    81.5 kB       0  [emitted]         dante
               dante.css.map    1.68 kB       0  [emitted]         dante
                  app.js.map     108 kB       1  [emitted]         app
                 app.css.map  503 bytes       1  [emitted]         app
        dante-vendors.js.map    1.58 MB       2  [emitted]         dante-vendors
                  index.html    2.32 kB          [emitted]
                license.html       2 kB          [emitted]
                    doc.html    2.06 kB          [emitted]
chunk    {0} dante.js, dante.css, dante.js.map, dante.css.map (dante) 96.4 kB {2} [initial] [rendered]
  [109] ./src/components/dante_editor.js 189 bytes {0} [built]
  [152] ./src/styles/fonts/dante/dante.eot 61 bytes {0} [built]
  [153] ./src/styles/fonts/dante/fontello.eot 64 bytes {0} [built]
  [172] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [175] ./demo/initialize.js 78 bytes {0} [built]
  [196] ./src/components/dante.js 176 bytes {0} [built]
  [207] ./src/index.js 417 bytes {0} [built]
  [335] ./src/styles/dante.scss 41 bytes {0} [built]
  [360] ./src/styles/fonts/dante/dante.svg 61 bytes {0} [built]
  [361] ./src/styles/fonts/dante/dante.ttf 61 bytes {0} [built]
  [362] ./src/styles/fonts/dante/dante.woff 62 bytes {0} [built]
  [363] ./src/styles/fonts/dante/fontello.svg 64 bytes {0} [built]
  [364] ./src/styles/fonts/dante/fontello.ttf 64 bytes {0} [built]
  [365] ./src/styles/fonts/dante/fontello.woff 65 bytes {0} [built]
  [414] multi (webpack)-dev-server/client?http://localhost:8081 webpack/hot/dev-server ./demo/initialize.js 52 bytes {0} [built]
     + 15 hidden modules
chunk    {1} app.js, app.css, app.js.map, app.css.map (app) 105 kB {2} [initial] [rendered]
  [172] (webpack)/hot nonrecursive ^\.\/log$ 160 bytes {0} {1} [built]
  [174] ./demo/demo.js 256 bytes {1} [built]
  [195] ./demo/data/poc.js 105 kB {1} [built]
  [332] ./demo/styles/layout/normalize.css 41 bytes {1} [built]
  [333] ./demo/styles/layout/layout.scss 41 bytes {1} [built]
  [334] ./demo/styles/layout/scaffold.scss 41 bytes {1} [built]
  [413] multi (webpack)-dev-server/client?http://localhost:8081 webpack/hot/dev-server ./demo/demo.js 52 bytes {1} [built]
chunk    {2} dante-vendors.js, dante-vendors.js.map (dante-vendors) 1.27 MB [entry] [rendered]
   [67] (webpack)-dev-server/client?http://localhost:8081 7.23 kB {2} [built]
   [68] (webpack)/hot/dev-server.js 1.57 kB {2} [built]
  [173] (webpack)/hot/emitter.js 77 bytes {2} [built]
  [369] ./~/loglevel/lib/loglevel.js 7.74 kB {2} [built]
  [370] ./~/punycode/punycode.js 14.7 kB {2} [built]
  [373] ./~/querystring-es3/index.js 127 bytes {2} [built]
  [406] ./~/strip-ansi/index.js 161 bytes {2} [built]
  [408] ./~/url/url.js 23.3 kB {2} [built]
  [410] (webpack)-dev-server/client/overlay.js 3.73 kB {2} [built]
  [411] (webpack)-dev-server/client/socket.js 1.04 kB {2} [built]
  [412] (webpack)/hot/log-apply-result.js 1.02 kB {2} [built]
  [415] ./~/css-loader!./demo/styles/layout/normalize.css 7.44 kB {2} [built]
  [417] ./~/css-loader!./~/sass-loader!./demo/styles/layout/scaffold.scss 215 bytes {2} [built]
  [418] ./~/css-loader!./~/sass-loader!./src/styles/dante.scss 40.4 kB {2} [built]
  [419] ./~/style-loader/addStyles.js 6.91 kB {2} [built]
     + 369 hidden modules
Child html-webpack-plugin for "doc.html":
    chunk    {0} doc.html 543 kB [entry] [rendered]
        [0] ./~/lodash/lodash.js 540 kB {0} [built]
        [1] ./~/html-webpack-plugin/lib/loader.js!./demo/assets/options.html 2.23 kB {0} [built]
        [2] (webpack)/buildin/global.js 509 bytes {0} [built]
        [3] (webpack)/buildin/module.js 517 bytes {0} [built]
Child html-webpack-plugin for "license.html":
    chunk    {0} license.html 543 kB [entry] [rendered]
        [0] ./~/lodash/lodash.js 540 kB {0} [built]
        [1] ./~/html-webpack-plugin/lib/loader.js!./demo/assets/license.html 2.17 kB {0} [built]
        [2] (webpack)/buildin/global.js 509 bytes {0} [built]
        [3] (webpack)/buildin/module.js 517 bytes {0} [built]
Child html-webpack-plugin for "index.html":
                           Asset     Size  Chunks             Chunk Names
    images/dante-editor-logo.png  1.61 kB          [emitted]
          images/github-logo.png  3.47 kB          [emitted]
    chunk    {0} index.html 543 kB [entry] [rendered]
        [0] ./src/images/site/dante-editor-logo.png 74 bytes {0} [built]
        [1] ./src/images/site/github-logo.png 68 bytes {0} [built]
        [2] ./~/lodash/lodash.js 540 kB {0} [built]
        [3] ./~/html-webpack-plugin/lib/loader.js!./demo/assets/index.html 2.61 kB {0} [built]
        [4] (webpack)/buildin/global.js 509 bytes {0} [built]
        [5] (webpack)/buildin/module.js 517 bytes {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 8.94 kB [entry] [rendered]
        [0] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
        [1] ./~/css-loader!./demo/styles/layout/normalize.css 7.44 kB {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 1.72 kB [entry] [rendered]
        [0] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
        [1] ./~/css-loader!./~/sass-loader!./demo/styles/layout/scaffold.scss 215 bytes {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 2.8 kB [entry] [rendered]
        [0] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
        [1] ./~/css-loader!./~/sass-loader!./demo/styles/layout/layout.scss 1.3 kB {0} [built]
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 42.4 kB [entry] [rendered]
        [0] ./src/styles/fonts/dante/dante.eot 61 bytes {0} [built]
        [1] ./src/styles/fonts/dante/fontello.eot 64 bytes {0} [built]
        [2] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]
        [3] ./src/styles/fonts/dante/dante.svg 61 bytes {0} [built]
        [4] ./src/styles/fonts/dante/dante.ttf 61 bytes {0} [built]
        [5] ./src/styles/fonts/dante/dante.woff 62 bytes {0} [built]
        [6] ./src/styles/fonts/dante/fontello.svg 64 bytes {0} [built]
        [7] ./src/styles/fonts/dante/fontello.ttf 64 bytes {0} [built]
        [8] ./src/styles/fonts/dante/fontello.woff 65 bytes {0} [built]
        [9] ./~/css-loader!./~/sass-loader!./src/styles/dante.scss 40.4 kB {0} [built]
webpack: Compiled successfully.
BafS commented 7 years ago

I just tried your pull and it's the same warnings. Are you sure you see the "warnings" ? It's on the client side.

image

The problem is with the static methods from Entity (ex Entity.get(entityKey).getType() in find_enties.js line 9).

michelson commented 7 years ago

Ah, I get it now, I've commited some changes in the PR #71 , there is only one deprecation now, I will try to fix this soon

BafS commented 7 years ago

Great, thank you

BafS commented 7 years ago

Would it be possible to push the new version on npm ? Thanks in advance !

BafS commented 6 years ago

Hi @michelson, any news about the PR ?

michelson commented 6 years ago

merged! thanks