search

michelve / software-license-manager

🔐Wordpress Software License Management. Supports WooCommerce, and WP eStore.
https://epikly.com
GNU General Public License v3.0
77 stars 27 forks source link

date() is used in this plugin. Would you mind using wp_date() introduced in WP 5.3? #29

Closed k-kikuchi-waverworks closed 3 years ago

k-kikuchi-waverworks commented 3 years ago

Thank you for providing very good product. I have found that your plugin still use date(), this may cause a issue for locale excerpt for US above WP 5.3. Would you mind using wp_date() introduced in WP 5.3 ?

https://developer.wordpress.org/reference/functions/wp_date/

Kings Regards

michelve commented 3 years ago

i will release this in the next release 5.5.8 thx

k-kikuchi-waverworks commented 3 years ago

Thank you for your working. I will wait for the release. Maybe, you simply just have to only replace date() with wp_date().

Regards

michelve commented 3 years ago

implemented in next release https://github.com/michelve/software-license-manager/commit/af90004fc95cf978cca3edb2298039735898749f