michelve / software-license-manager

🔐Wordpress Software License Management. Supports WooCommerce, and WP eStore.
https://epikly.com
GNU General Public License v3.0
77 stars 27 forks source link

HTML markup is incorrect in wc_licenses_class.php #38

Closed k-kikuchi-waverworks closed 3 years ago

k-kikuchi-waverworks commented 3 years ago

Thank you for fixing https://github.com/michelve/software-license-manager/issues/33. I say big thanks to you.

However, this fix caused an another issues.

<td class="slm-view" data-title="<?php echo __('view', 'softwarelicensemanager'); ?>><a href="" class=" woocommerce-button button view"><?php echo _e('view'); ?></a></td>

is incorrect HTML markup.

Please fix this <td class="slm-view" data-title="<?php echo __('view', 'softwarelicensemanager'); ?>"><a href="" class=" woocommerce-button button view"><?php echo _e('view'); ?></a></td>

You miseed " for data-title attribute.

Also, you missed to add data-title attribute for Order column.

<td class="woocommerce-orders-table__cell woocommerce-orders-table__cell-order-number slm-order"><a href="<?php echo get_site_url() . '/my-account/view-order/' . $license_info->purchase_id_; ?>">#<?php echo $license_info->purchase_id_; ?></a></td>

is should be

<td class="woocommerce-orders-table__cell woocommerce-orders-table__cell-order-number slm-order" data-title="<?php echo __('Order', 'softwarelicensemanager'); ?>"><a href="<?php echo get_site_url() . '/my-account/view-order/' . $license_info->purchase_id_; ?>">#<?php echo $license_info->purchase_id_; ?></a></td>

King Regards KAZUKI