search

michie1 / bc

Script that reads all orders of a topic from wtos.nl, puts everything in the cart of bike-components.de and generates a Google spreadsheet with Python, lxml, Google API, Docker
5 stars 5 forks source link

Deprecate directory config.dir #21

Closed michie1 closed 4 years ago

michie1 commented 4 years ago
  • [ ] Deprecate directory config.dir

By accident I found this commit: 442445fb29547caac9eb8f64378769390ab132b5. So the config.directory was added to make the script work with cronjob. I am not familiar with cronjob and don't know if this is necessary but I think it is useful to know why you @michie1 put it there in the first place.

Originally posted by @bcvanmeurs in https://github.com/michie1/bc/issues/13#issuecomment-554937841

michie1 commented 4 years ago

Ah Yes, I forgot. I wrote that nearly two years ago. Thanks for reminding me.

The cronjob is defined in crontab.txt. I think I can change /usr/local/bin/python /src/main.py >> /src/log.txt to cd /src && /usr/local/bin/python main.py >> log.txt and be able to deprecate the directory value in the config.