search

michiel / jsonapi-rust

Rust library for serialization, deserialization and working with JSON-API data
MIT License
109 stars 30 forks source link

Don't suppress errors of serde_json #66

Closed therustmonk closed 5 years ago

therustmonk commented 5 years ago

This PR discloses original serde_json::Error. It's hard to debug large models if errors are suppressed.

codecov-io commented 5 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          10       10           
  Lines        1174     1174           
=======================================
  Hits         1070     1070           
  Misses        104      104
Impacted Files Coverage Δ
src/errors.rs 0% <ø> (ø) :arrow_up:
src/model.rs 89.92% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35390e5...3b70f04. Read the comment docs.

michiel commented 5 years ago

Good one :+1:

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.