michiel / jsonapi-rust

Rust library for serialization, deserialization and working with JSON-API data
MIT License
110 stars 30 forks source link

Remove test-related structs from src/model. #68

Closed guidorice closed 4 years ago

guidorice commented 5 years ago

Thanks for making this crate, although I have not really used it yet, it def. could come in handy. I noticed there seems to be some leftover test-related structs (Dog and Flea) in model.rs.

guidorice commented 5 years ago

Oops I missed the contribution guidelines but I seem them now. This PR probably does not affect the changelog.

codecov-io commented 5 years ago

Codecov Report

Merging #68 into master will decrease coverage by 0.33%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage    90.8%   90.46%   -0.34%     
==========================================
  Files          10        9       -1     
  Lines        1185     1175      -10     
==========================================
- Hits         1076     1063      -13     
- Misses        109      112       +3
Impacted Files Coverage Δ
src/model.rs 89.14% <ø> (-0.78%) :arrow_down:
tests/api_test.rs 90.7% <0%> (-1.29%) :arrow_down:
src/query.rs 81.42% <0%> (-0.72%) :arrow_down:
src/lib.rs
tests/query_test.rs 95.42% <0%> (+0.27%) :arrow_up:
tests/model_test.rs 90% <0%> (+1.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dfb34a...875f6fd. Read the comment docs.

JadedEvan commented 4 years ago

@guidorice just to keep things tidy - would you be open to rebasing your changes to modify the commit message per the contribution guidelines? I'd think refactor is probably the most appropriate tag for your work here (conventional docs)

guidorice commented 4 years ago

Sure, will do! 👍

guidorice commented 4 years ago

@JadedEvan please let me know if the PR looks OK now. Thanks

JadedEvan commented 4 years ago

Looking good @guidorice - thanks for accommodating the changes! We've yanked codecov on this project since it wasn't adding much value, we can ignore those failures on this latest CI build.