Allow setting lightstates when creating scenes

michielpost / Q42.HueApi

C# helper library to talk to the Philips Hue bridge

MIT License

411 stars 114 forks source link

Allow setting lightstates when creating scenes #244

Closed joukevandermaas closed 3 years ago

joukevandermaas commented 3 years ago

This fixes a small bug in the CreateSceneAsync and UpdateSceneAsync methods on the HueClient. The lightstates property was removed after serializing because according to the comment, it should not be settable. However, according to the documentation and my testing, it is possible (and in fact very useful) to set it.

With this PR, the property will no longer be ignored when creating/updating a scene.

michielpost commented 3 years ago

Thanks! Looks good to me. I'll do some testing after the merge.

michielpost commented 3 years ago

I ran into some issues updating scenes, unrelated to this PR. So I did some more fixes (not sending group/type/empty appdate). Can you test if the current master branch still works for you? If it works I'll create a new release for NuGet.

joukevandermaas commented 3 years ago

@michielpost I tested it just now, it works great for me. Thanks for merging this so quickly!

michielpost commented 3 years ago

Version 3.17.0 is now up on NuGet.