search

michitaro / healpix

An implementation of HEALPix in JavaScript / TypeScript
MIT License
13 stars 4 forks source link

Algorithm in disk query? #12

Open cdeil opened 6 years ago

cdeil commented 6 years ago

@michitaro - Is the algorithm you use for disk query described somewhere? (a webpage or paper?)

If no, could you please add a few comments to the docstring to make it easier to understand what it does? https://github.com/michitaro/healpix/blob/99f23056210e6a8d0df60b72d36afc7d93627d5c/src/index.ts#L135

cdeil commented 6 years ago

I've found a description of the HEALPix query algorithm used in the C++ implementation: See Section 7 in http://adsabs.harvard.edu/abs/2015A&A...580A.132R

I still have to review and understand the call-back based implementation here by @michitaro and the algorithm by @dstndstn in here.

@michitaro @dstndstn - Can you comment on how your implementation compares to the one proposed there, and which one you think we should use (here in the Typescript and there in the C implementation)?