michitux / dokuwiki-plugin-move

Move and rename pages and namespaces whilst maintaining the links
http://www.dokuwiki.org/plugin:move
GNU General Public License v2.0
40 stars 20 forks source link

old revisions hyperlinks gone after renaming page on dokuwiki 2024-02-06b "Kaos" #281

Open Windows-Is-Cancer opened 2 months ago

Windows-Is-Cancer commented 2 months ago

Hi there,

i ran dokuWiki for quiet some years now (greebo with move plugin). worked a treat so far. now since it is outdated and unsecure we want to upgrade to a all new DW install using dokuwiki 2024-02-06b "Kaos" with the "move" plugin as linked on DWs plugin wiki page.

our dw directory has been migrated to new server/container. every old plugin has been deleted, then DW and all plugins freshly downloaded and installed. DW mainly works with all data, including page history (old revisions).

However, when i rename/move an existing page (with years of history) today using the "move" plugin, it seems it successfully renames the page, but all the historic references (hyperlinks) are now gone on the "old revisions" page. Thus a change cannot be reverted, since i cannot go to any older/previous page version.

interestingly, further/new changes to the "renamed page" are again revisioned correctly.

The DW logs show me "some" "move" related entries, but nothing i can understand or can link to this effect for sure. here is what i found in DW's deprecated logs about "move":

i tried to attach a screenshot here. did not really work somehow.

2024-09-19 12:45:06JSON::encode() is deprecated. It was called from action_plugin_move_rename::handle_ajax() in /var/www/html/lib/plugins/move/action/rename.php:118 json_encode should be used instead!
2024-09-19 12:45:06trigger_event() is deprecated. It was called from helper_plugin_move_rewrite::rewrite() in /var/www/html/lib/plugins/move/helper/rewrite.php:237 \dokuwiki\Extension\Event::createAndTrigger should be used instead!
2024-09-19 12:45:06Doku_Parser::__construct() is deprecated. It was called from helper_plugin_move_rewrite::rewrite() in /var/www/html/lib/plugins/move/helper/rewrite.php:242 dokuwiki\Parsing\Parser should be used instead!
2024-09-19 12:45:06helper_plugin_move_handler::_finalize() is deprecated. It was called from dokuwiki\Parsing\Parser::parse in /var/www/html/inc/Parsing/Parser.php:124 finalize() should be used instead!

Can anyone confirm this problem?

regards Axel

Windows-Is-Cancer commented 2 months ago

screenshot goes here.. hopefully. no. no it wont.

Windows-Is-Cancer commented 2 months ago

a small update on this: i just tested the "move" (rename) on a "virgin"/vanilla DW Kaos installation + move plugin and tested it on a new page. it failed in exactly the same way as described.

i also tested a vanilla "official dokuwiki docker image" container. Same problem there.

so something is off, compared to earlier versions of the "move" plugin.

Windows-Is-Cancer commented 2 months ago

i did not found any other similar issue so far here, BUT i found this merge/pull request here that seems to handle with the same problem, if i understand it correctly.

https://github.com/michitux/dokuwiki-plugin-move/pull/247/files

@splitbrain Hello Andi, sorry to bother you, but i hope you receive this notification. because this plugin to me seems BROKEN, thus your plugins website claims its compatible with the latest DW. but it fails the page history as mentioned here AND mentioned in that other pull request.

The pull request already is ONE YEAR OLD and it seems it's not been included in the recent version, even it looks working to me. i tested a vanilla DW+MOVE install and simply put that one patched helper/file.php in and tested the renaming thing with the history again. to me it seems to solve the problem.

however i am not qualified to evaluate all the aspects of the patch (can edit text files, can't understand php)

Can you please confirm the problem and somehow merge and test the patch for the move plugin so one can get the official version running again? thanks! Axel