Fix for #12 - Githubissues

ghost commented 2 years ago

Additionally corrected spelling and formatting errors

michmich112 commented 2 years ago

@luke-hagar-sp Awesome contribution! thank you so much! Did you use ES-Lint for these formatting corrections? If so would be good to add the ESlint config file for future updates to keep the same formatting

ghost commented 2 years ago

Hey @michmich112,

I just used the default VS Code Prettier plugin default configuration, I have my IDE set to format on Save.

Apologies if they are deviations from your standard.

michmich112 commented 2 years ago

Hey @luke-hagar-sp Can you follow the steps in this stack overflow answer to send the configs on your system. I like them and want to make sure we add a prettier config file to make sure that future changes abide to that format.

link: https://stackoverflow.com/a/53419053/11521081

ghost commented 2 years ago

@michmich112 There is no way to export the defaults as a file, but I went ahead and gathered them here.

{
arrowParens: "always",
bracketSameLine: false,
bracketSpacing: true,
embeddedLanguageFormatting: "auto",
endOfLine: "lf",
filepath: undefined,
htmlWhitespaceSensitivity: "css",
insertPragma: false,
jsxBracketSameLine: false,
jsxSingleQuote: false,
parser: undefined,
printWidth: 80,
proseWrap: "preserve",
quoteProps: "as-needed",
rangeEnd: Infinity,
requirePragma: false,
semi: true,
singleQuote: false,
tabWidth: 2,
trailingComma: "es5",
useTabs: false,
vueIndentScriptAndStyle: false
}

michmich112 commented 2 years ago

Ok merging into fix/#12 and adding your prettier configuration. This will be included in release 1.2.2 Thank You!

ghost commented 1 year ago

Hey Mich,

I just used the default VS Code Prettier plugin default configuration, I have my IDE set to format on Save.

Apologies if they are deviations from your standard.

Luke

From: Akumetsu @.> Date: Tuesday, August 16, 2022 at 12:59 PM To: michmich112/sveltekit-adapter-chrome-extension @.> Cc: Luke Hagar @.>, Author @.> Subject: Re: [michmich112/sveltekit-adapter-chrome-extension] Fix for #12 (PR #13) Did you use ES-Lint for these formatting corrections? If so would be good to add the ESlint config file for future updates to keep the same formatting — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd

Did you use ES-Lint for these formatting corrections? If so would be good to add the ESlint config file for future updates to keep the same formatting

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/michmich112/sveltekit-adapter-chrome-extension/pull/13*issuecomment-1216969274__;Iw!!MsNKLpFGsw!KDfcuxhGx1-wnAueeHAbvlOJ4Cnip_kzTfWQvLbqjqOSGHqjqmvSbw-ERWOwxzNJH0352G_rLOvt2xTki77CAemNhcE$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AXSFHH3UFPP3KTGXADC7GQTVZPJGHANCNFSM56WVIX6Q__;!!MsNKLpFGsw!KDfcuxhGx1-wnAueeHAbvlOJ4Cnip_kzTfWQvLbqjqOSGHqjqmvSbw-ERWOwxzNJH0352G_rLOvt2xTki77Cr7lCvaE$. You are receiving this because you authored the thread.Message ID: @.***>

michmich112 commented 1 year ago

@luke-hagar-sp No problem! I didn't set a standard, so you've just created it :) Thank you once again for your hard work and contribution!

michmich112 / sveltekit-adapter-chrome-extension

Fix for #12 #13