search

michmich112 / sveltekit-adapter-chrome-extension

Sveltekit adapter for making chrome extensions
MIT License
108 stars 17 forks source link

wrap @sveltejs/adapter-static #29

Closed wallw-teal closed 1 year ago

wallw-teal commented 1 year ago

This helps us more easily keep up with changes in the official svelte packages by using it directly and then doing our extra changes afterward.

One downside to this is that emptyOutDir is no longer a valid option, and the directory is always emptied by the adapter-static adapt function.

fixes #28

I also noticed that eslint/prettier/tests/tsc are not configured inside the reop, despite appearing in package.json. So fingers crossed those all pass 🤞. Additionally, I think I'm using a newer version of npm and it wanted to rewrite the package-lock.json. I can knock that out of the commit if that is annoying (that is causing the large diff).

michmich112 commented 1 year ago

I like this ! Great job @wallw-teal this will definitely help for keeping in sync with future Sveltekit changes

Due to the deprecation of the emptyOutDir api, we'll mark this as a new major version: v2.0.0 Users will still be able to use the emptyOutDir api in v1.X!

Thank you for your contribution!