michodgs25 / Somerset-Trails

Find local and national parks in the Somerset Area
1 stars 1 forks source link

Bugs& Errors - Banner #8

Open michodgs25 opened 4 years ago

michodgs25 commented 4 years ago

Banner

/*tablet banner size*/
@media screen and (max-width: 64.375em) {
    .banner {
        width: 100%;
        height: 18em;
    }
}

/*container*/
@media screen and (max-width: 64.375em) {
    .banner-outer {
        width: 100%;
        height: 18em;
    }
}
/*mobile banner size*/
@media screen and (max-width: 37.5em) {
    .banner{
        width: 100%;
        height: 15em;
    }
}
/*container*/
@media screen and (max-width: 37.5em) {
    .banner-outer {
        width: 100%;
        height: 15em;
    }
}

An unfortunate side effect of implementing a solution to the inline maps issue is having to add an additional script to the footer of the page. The site was having loading issues prior to this and now the main banner sometimes does not appear at all. The page has to be refreshed for this to happen, this occurs on desktop screens where the banner is at its largest.

Summary:

The banner works as intended once the page is refreshed, future iterations to look at ways to resolve the issue by reducing the file size or a way to help the browser load an image of that size more efficiently.