Open iGuaZi opened 4 years ago
Thanks! Where are Note1, Note2 and Note3?
in comments, e.g. at the line: all_cmc.append(cmc[:max_rank])
I consider you are right. However, num_g should less than max_rank in logically. If you encounter a bug, you can set max_rank < num_q, or modify the code with 'try & except'.
the question is that I don't think the eval code is correct, because it could change the rank. oric_cmc[0]
may not be the top 1 rank
orig_cmc = matches[q_idx][keep] # NOTE1: variable length
I think the following is correct
matches[q_idx][remove]=0
oric_cmc = matches[q_idx]
Hi, I believe there is an error. Lines with NOTE1 and NOTE2 may cause error in NOTE3., especially when num_g < max_rank.