search

micjahn / Griffith

GNU General Public License v2.0
10 stars 8 forks source link

Updated loading plot from IMDB #1

Closed HannsWeschta closed 7 years ago

HannsWeschta commented 7 years ago

Related to Launchpad Bug #1721640: "Movie Plot/Summary not populating well". See https://bugs.launchpad.net/griffith/+bug/1721640. The original code didn't find any plot-related text, because the class "plotSummary" is gone on the plotsummary page. So the plot from the main movie page was provided. I created this as a kind of "fallback". If it can find the plot with id="plot-summaries-content" on the plotsummary page, it will try to harvest all descriptions found there and provide this as plot. Else the plot from the main page succeedes. I have also implemented this for IMDB-de, because the content is almost the same. Maybe we should consider to consolidate these language dependent import filters for IMDB? Some more investigation on this is needed.

micjahn commented 7 years ago

The different language-specific versions of the IMDb plugin should be removed. The websites don't exist anymore (since 2013). As far as I understand there are only the country specific titles available, f.e.: http://www.imdb.com/title/tt0092455/releaseinfo?ref_=ttfc_ql_2#akas The main plugin should fetch it automatically based on the locale settings of the computer.