search

micjahn / ZXing.Net

.Net port of the original java-based barcode reader and generator library zxing
Apache License 2.0
2.7k stars 666 forks source link

Improve reading of degraded Cab128 #434

Open EricB84300 opened 2 years ago

EricB84300 commented 2 years ago

Hi @micjahn For one of our customers, we have developed an improvement for reading degraded code128. We used the white parts to read the characters and got great results. So we want offer this code to the community How can we propose you this pull request it seems I don't have the right to push it.

micjahn commented 2 years ago

Hi,

thanks for your work. You should create a fork from the master branch and then create a pull request with your changes.

Michael

Von: EricB84300 @.> Gesendet: Monday, July 18, 2022 11:54:19 AM An: micjahn/ZXing.Net @.> Cc: Michael Jahn @.>; Mention @.> Betreff: [micjahn/ZXing.Net] Improve reading of degraded Cab128 (Issue #434)

Hi @micjahnhttps://github.com/micjahn For one of our customers, we have developed an improvement for reading degraded code128. We used the white parts to read the characters and got great results. So we offer you this code. How can we propose you this pull request it seems I don't have the right to push it.

— Reply to this email directly, view it on GitHubhttps://github.com/micjahn/ZXing.Net/issues/434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA2QMUTMXTZJJUYMPMI6KY3VUUSUXANCNFSM533UVKSA. You are receiving this because you were mentioned.Message ID: @.***>

EricB84300 commented 2 years ago

Hi I will do that this afternoon. thx for so quick answer. Eric

EricB84300 commented 2 years ago

Pull Request done

micjahn commented 1 year ago

Thanks. Please be patient. Too much work, too less time.

EricB84300 commented 1 year ago

No pb we all know that 😉

micjahn commented 1 year ago

You can make slow. I can‘t review it within the next 2 weeks. Michael

Von: EricB84300 @.> Gesendet: Monday, July 18, 2022 12:12:53 PM An: micjahn/ZXing.Net @.> Cc: Michael Jahn @.>; Mention @.> Betreff: Re: [micjahn/ZXing.Net] Improve reading of degraded Cab128 (Issue #434)

Hi I will do that this afternoon. thx for so quick answer. Eric

— Reply to this email directly, view it on GitHubhttps://github.com/micjahn/ZXing.Net/issues/434#issuecomment-1187015552, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA2QMURPTIKYTAHHYNWE76DVUUU2LANCNFSM533UVKSA. You are receiving this because you were mentioned.Message ID: @.***>