search

micjahn / ZXing.Net

.Net port of the original java-based barcode reader and generator library zxing
Apache License 2.0
2.7k stars 668 forks source link

ZXing.Net Bindings for SkiaSharp Package missing Linux #544

Open ahmed-abdelrazek opened 8 months ago

ahmed-abdelrazek commented 8 months ago

it comes with image but not image

mathy-plutoflume commented 8 months ago

Version 2.88.3 has vulnerabilities (#545) can the package also be upgraded when above issue is worked on.

ahmed-abdelrazek commented 8 months ago

Version 2.88.3 has vulnerabilities (#545) can the package also be upgraded when above issue is worked on.

they already updated it to 2.88.6 but didn't push a new package yet https://github.com/micjahn/ZXing.Net/commit/6d11086589e8b567060a5ab9fe145573cd5c9895

micjahn commented 8 months ago

The SkiaSharp.NativeAssets.* dependencies are added transitively by the SkiaSharp package. I have no idea how to add the package SkiaSharp.NativeAssets.Linux correctly to the SkiaSharp binding package. And in my opinion, it should not be necessary. What do you think about adding the package manually to your project which uses the SkiaSharp binding package?

ahmed-abdelrazek commented 8 months ago

i did add it manually which fixed my problem (running asp core web api on linux with skiasharp renderer) but the point is i shouldn't have to because i expect my cross platforms library to by cross platforms in hindsight it's on SkiaSharp project including just windows and mac by default and not linux as well they have whole section on their readme about this issue https://github.com/mono/SkiaSharp#using-skiasharp https://github.com/mono/SkiaSharp/issues/453

i guess you can also add the SkiaSharp.NativeAssets.Linux library manually just like SkiaSharp itself until they fix their package as temporary (with fanky support) fix for anyone that except it to work out of the box like me or leave this issue open for any one that is asking