mickael-kerjean / filestash

🦄 A file manager / web client for SFTP, S3, FTP, WebDAV, Git, Minio, LDAP, CalDAV, CardDAV, Mysql, Backblaze, ...
https://www.filestash.app/
GNU Affero General Public License v3.0
10.09k stars 739 forks source link

[bug] Filestash not playing videos in browser #617

Open bossrhino opened 1 year ago

bossrhino commented 1 year ago

Description of the bug

Unable to play videos in browser once Filestash container has launched.

Step by step instructions to reproduce the bug

  1. Launch an instance of the Filestash docker container
  2. Setup basic admin configuration with S3 as the backend storage. Making sure transcoding is enabled. And that their are no video formats blacklisted.
  3. Launch the site, and provide the required s3 credentials to the s3 bucket.
  4. Navigate to a directory with a video > load the video > Uncaught ReferenceError: t is not defined

Observed behavior

Playing a .mov, .mkv, .mp4, and .wmv within a browser

Uncaught ReferenceError: t is not defined

Expected behavior

Expected behavior would be that a video file plays within the browser. Not sure what's up as of right now :( Any assistance is appreciated

bossrhino commented 1 year ago

Not sure if this helps, but this is what the logs at the lowest level show:

2023-06-29 15:36:42 2023/06/29 22:36:42 HTTP 200 GET 65.6ms /api/files/ls?path=%2Fjeffs-repo%2FMovies%2F 2023-06-29 15:36:49 2023/06/29 22:36:49 HTTP 200 GET 5120.3ms /api/files/cat?path=%2Fjeffs-repo%2FMovies%2FNew%20Features%20for%20Building%20Powerful%20Containerized%20Microservices%20on%20AWS%20-%20AWS%20Online%20Tech%20Talks.mp4&transcode=hls 2023-06-29 15:36:50 2023/06/29 22:36:50 HTTP 200 GET 1626.1ms /hls/hls_0.ts?path=vid_NgdFduQPbuc1bnblOdLd_kMbBdZd4dC.dat 2023-06-29 15:36:50 2023/06/29 22:36:50 HTTP 200 POST 0.1ms /report?url=http%3A%2F%2Flocalhost%3A8443%2Fview%2Fjeffs-repo%2FMovies%2FNew%2520Features%2520for%2520Building%2520Powerful%2520Containerized%2520Microservices%2520on%2520AWS%2520-%2520AWS%2520Online%2520Tech%2520Talks.mp4&msg=Uncaught%20ReferenceError%3A%20t%20is%20not%20defined&from=blob%3Ahttp%3A%2F%2Flocalhost%3A8443%2F4297e113-7456-434b-bc23-70a4b2e11ccf&from.lineNo=1&from.columnNo=100 2023-06-29 15:36:52 2023/06/29 22:36:52 HTTP 200 GET 1486.2ms /hls/hls_1.ts?path=vid_NgdFduQPbuc1bnblOdLd_kMbBdZd4dC.dat 2023-06-29 15:36:54 2023/06/29 22:36:54 HTTP 200 GET 1571.0ms /hls/hls_0.ts?path=vid_NgdFduQPbuc1bnblOdLd_kMbBdZd4dC.dat 2023-06-29 15:37:23 2023/06/29 22:37:23 HTTP 200 GET 0.1ms /admin/api/session

qlyoung commented 1 year ago

I also have this issue.

Scyne commented 1 year ago

also having this issue. When trying to watch the breakpoints I'm getting TypeError: Failed to construct 'VTTCue': The provided double value is non-finite. Dont know If that helps?

neingeist commented 1 year ago

This also happens with the demo videos on the demo at https://demo.filestash.app:

image

This is Chrome, but the same happens in Firefox. No other issues with the demo, I think (can't upload or create folders, but that is probably intended.)

awg13 commented 1 year ago

Uncaught ReferenceError: t is not defined Can also confirm this is happening when trying to play videos through browser. Hope there will be a fix in future.

alanmilinovic commented 1 year ago

Also confirm.

Stormrice commented 1 year ago

For me, videos are playing when I disable the transcoder option.

alanmilinovic commented 1 year ago

For me, videos are playing when I disable the transcoder option.

Then you are losing on performance for viewers with slower Internet speed, resulting in bad viewing experience.

qlyoung commented 1 year ago

If those users cannot play the video with the transcoding option turned on I don't think they're losing anything

On Mon, Sep 25, 2023, at 11:22 AM, Alan wrote:

For me, videos are playing when I disable the transcoder option.

Then you are losing on performance for viewers with slower Internet speed, resulting in bad viewing experience.

— Reply to this email directly, view it on GitHub https://github.com/mickael-kerjean/filestash/issues/617#issuecomment-1733940299, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX6YT3KKGFR2E3ZHBE4LX4GOS5ANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.***>

alanmilinovic commented 1 year ago

If those users cannot play the video with the transcoding option turned on I don't think they're losing anything On Mon, Sep 25, 2023, at 11:22 AM, Alan wrote: > For me, videos are playing when I disable the transcoder option. > Then you are losing on performance for viewers with slower Internet speed, resulting in bad viewing experience. — Reply to this email directly, view it on GitHub <#617 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX6YT3KKGFR2E3ZHBE4LX4GOS5ANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.***>

It is a global option so others that can play and have slow Internet will suffer.

qlyoung commented 1 year ago

No one can play any videos when transcoding is enabled. That is the whole point of this bug.

On Mon, Sep 25, 2023, at 11:25 AM, Alan wrote:

If those users cannot play the video with the transcoding option turned on I don't think they're losing anything … <#> On Mon, Sep 25, 2023, at 11:22 AM, Alan wrote: > For me, videos are playing when I disable the transcoder option. > Then you are losing on performance for viewers with slower Internet speed, resulting in bad viewing experience. — Reply to this email directly, view it on GitHub <#617 (comment) https://github.com/mickael-kerjean/filestash/issues/617#issuecomment-1733940299>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX6YT3KKGFR2E3ZHBE4LX4GOS5ANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.***>

It is a global option so others that can play and have slow Internet will suffer.

— Reply to this email directly, view it on GitHub https://github.com/mickael-kerjean/filestash/issues/617#issuecomment-1733949410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX66MXGLGNS46FTXFBQ3X4GO7PANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.***>

alanmilinovic commented 1 year ago

No one can play any videos when transcoding is enabled. That is the whole point of this bug. On Mon, Sep 25, 2023, at 11:25 AM, Alan wrote: > > If those users cannot play the video with the transcoding option turned on I don't think they're losing anything > … <#> > On Mon, Sep 25, 2023, at 11:22 AM, Alan wrote: > For me, videos are playing when I disable the transcoder option. > Then you are losing on performance for viewers with slower Internet speed, resulting in bad viewing experience. — Reply to this email directly, view it on GitHub <#617 (comment) <#617 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX6YT3KKGFR2E3ZHBE4LX4GOS5ANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.> > It is a global option so others that can play and have slow Internet will suffer. — Reply to this email directly, view it on GitHub <#617 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCX66MXGLGNS46FTXFBQ3X4GO7PANCNFSM6AAAAAAZZC6O4Q. You are receiving this because you commented.Message ID: @.>

Ok, wasn't aware that nobody can play it because you mentioned "those users...".

pavelsr commented 2 months ago

I noticed that *.mp4 and *.webm formats (and possibly all HTML5 video formats that can be used with <video> tag) are played fine in Filestash even if video is large and 4K resolutuion and regardless on plg_video_transcoder plugin status (disabled or enabled)

# ✅ streams fine
$ file 1.mp4 
1.mp4: ISO Media, MPEG v4 system, Dynamic Adaptive Streaming over HTTP

# ⚠️ play only audio, not video 
$ file 2.mp4 
2.mp4: ISO Media, MP4 v2 [ISO 14496-14]

# ❌ not playing (progress circle hanging)
$ file 3.mkv
3.mkv: Matroska data

And enabling video transcoder didn't help to play non-HTML5 formats. Today I opened separate issue about documenting this feature: https://github.com/mickael-kerjean/filestash/issues/716

My Filestash version is v0.5.20240705