mickael-kerjean / filestash

🦄 A file manager / web client for SFTP, S3, FTP, WebDAV, Git, Minio, LDAP, CalDAV, CardDAV, Mysql, Backblaze, ...
https://www.filestash.app/
GNU Affero General Public License v3.0
10.29k stars 763 forks source link

OnlyOffice integration broken since refactor to make configuration dynamic #682

Open SteffeyDev opened 7 months ago

SteffeyDev commented 7 months ago

Description of the bug

I noticed that only office integration was broken in the latest version (8ece5301dbb9a03be2a7be70c9bc70b39b6dd9e8). The onlyoffice plugin was modified in https://github.com/mickael-kerjean/filestash/commit/9e142d5de5dd58391ec40eb1fc4ccc85faac994c, so I pulled the commit before that (845c4584d37097414e2c1fab55ef1327df003b56) and confirmed that onlyoffice worked before that, so something in that commit must have broken onlyoffice. With the latest commit it only shows a blank page and is returning a 404 for /api/onlyoffice/iframe.

OnlyOffice does seem to be working in the demo site, not sure which commit that is running.

Step by step instructions to reproduce the bug

Using 8ece5301dbb9a03be2a7be70c9bc70b39b6dd9e8

  1. Modify the default config to add onlyoffice:
    "features": {
    "office": {
            "enable": true,
            "onlyoffice_server": "http://localhost:8080",
            "can_download": true
        }
    }
  2. Login with the local backend
  3. Create and open a .docx file

Observed behavior

The page for a .docx document is blank

Expected behavior

OnlyOffice should load to allow editing the .docx in the browser

grozadanut commented 2 months ago

It seems that the demo doesn't work either, at least for me.

https://demo.filestash.app/view/Documents/office.docx

If I look in the browser console I get the error: Uncaught SyntaxError: Unexpected token '%'

homegrownhrbs commented 2 months ago

Same Issue for me, fresh install.

Unable to view, edit or share any office docs via filestash.

Images and .md files seem to work but no documents work in my install or on the demo server.

grozadanut commented 1 month ago

I believe this issue has been fixed with the latest commits. I verified with the official demo and it works. My proposal is to mark this issue as resolved, if SteffeyDev and homegrownhrbs could also confirm it works.