mickael-kerjean / filestash

🦄 A file manager / web client for SFTP, S3, FTP, WebDAV, Git, Minio, LDAP, CalDAV, CardDAV, Mysql, Backblaze, ...

https://www.filestash.app/

GNU Affero General Public License v3.0

10.61k stars 789 forks source link

[bug] Filenames containing a ":" fail to upload. #765

Open clanktron opened 2 weeks ago

clanktron commented 2 weeks ago

Description of the bug

Filename is incorrectly stated as invalid and upload fails.

Open Screenshot 2024-08-24 at 04:50:30 PM.png: response error: The object name is invalid.

Step by step instructions to reproduce the bug

Storage backend is samba, the file can be copied over without issues via samba normally. Filestash seems to be doing some sort of internal validation of the filename that incorrectly states it to be invalid.

Can you replicate that error from the demo?

The demo doesn't appear to accept any uploads in general so this isn't testable.

mickael-kerjean commented 2 weeks ago

Can you provide a step by step for me to replicate this? I can't seem to replicate the error on my end:

screenshot-20241111-041238Z-all

clanktron commented 2 weeks ago

I started a local testing instance with:

[I] clayton@fedora ~ > podman run  --name filestash-demo -p 8334:8334 machines/filestash
2024/11/12 21:00:35 SYST INFO [http] starting ...
2024/11/12 21:00:36 SYST INFO [http] listening on :8334

Configuration of samba connection: Screenshot From 2024-11-12 13-07-32

Unsuccessful upload with filename containing ":", followed by a successful upload of a file without such. It also works with the same file if I simply remove the ":"s in the filename.

Screencast From 2024-11-12 13-04-52.webm