search

mickael9 / ioq3

This is an up-to-date fork of ioquake3 for UrbanTerror with changes from the ioUrbanTerror engine
GNU General Public License v2.0
42 stars 18 forks source link

Protocol 71 is not supported by any GTV server #15

Closed alexanderkress closed 6 years ago

alexanderkress commented 6 years ago

Do not use protocol 71, the same mistake was done by FrozenSand for release 4.2.001. All GTV servers support only protocol 68, so this binary is a no-go for any league.

danielepantaleone commented 6 years ago

Did you try to set com_legacyprotocol to 1?

EDIT: I agree that having a different protocol set it's quite useless. I'll try to get a pull request to solve this issue. Sorry, my mistake. It seems that protocol version 71 has been introduced by ioquake (see: https://github.com/ioquake/ioq3/commit/2349148cf1b8cc80ad3d907881e6c53c2248fa92) so setting com_legacyprotocol to 1 here is the way to go. This ensure to stay compatible with the original ioquake fork and Urban Terror as well.

alexanderkress commented 6 years ago

No, I did not, since it is not listed in the readme. I know that port 71 is the default in ioquake, however, if this shall be a binary for UrT, the default should be protocol 68 with the option to switch to a different protocol version. At least a hint in the readme would be required, that the server.conf shall set the com_legacyprotocol value to 1.

danielepantaleone commented 6 years ago

I don't think protocol 68 will be set to the default since it will require many changes to the engine code and it's just not worth. I'd go for the cvar set in the server initialization parameters.

alexanderkress commented 6 years ago

agreed, so at least the readme here should get a hint and inform about the option com_legacyprotocol.

KroniK907 commented 6 years ago

@BidyBiddle It looks like you canceled a pull request to add this to the readme. Can you add it and close this?

BidyBiddle commented 6 years ago

From what I understood, the legacyprotocol is "on" and works by default, no?

Also, these vars are described in the ioquake3 readme, this is why I thought it wasn't necessary to do it again in the repo's readme. You think it's needed in the second too?

KroniK907 commented 6 years ago

If its already in the ioquake3 readme then it should be fine to leave it out of the readme for this repo. I was just hoping to clear the issue queue and this seemed like one that would be very easy to go ahead and close.

BidyBiddle commented 6 years ago

Okay cool.

Yeah, you can find it here in the New Cvars under Console. People can also jut look here too. If they land on this issue after a quick search.