search

mickael9 / rvgl-flatpak

7 stars 0 forks source link

Should we bundle RVGL dependencies? #4

Open gk7huki opened 6 months ago

gk7huki commented 6 months ago

In addition the to the Launcher's dependencies, shouldn't we also add RVGL's own dependencies (sdl2, openal, enet and so on) to the flatpak?

mickael9 commented 6 months ago

I suppose it would be better practise to do so.

But since they are already shipped with RVGL itself, I figured it was unnecessary to build them from source (it already takes more than an hour to build all the deps!)

It would be so much better if flatpak builder would have some sort of binary package system

What do you think @AsciiWolf ?

gk7huki commented 6 months ago

But since they are already shipped with RVGL itself, I figured it was unnecessary to build them from source (it already takes more than an hour to build all the deps!)

Only a few dependencies are shipped with RVGL. You can find the full list of RVGL dependencies here.

But I have good news: the flatpak includes the freedesktop.platform which in fact contains almost all our dependencies, with the exception of enet, unistring and fluidsynth. Of these, enet and unistring are shipped with RVGL, and fluidsynth is optional.

So it seems we have no need to build / include any other deps. :) Maybe we can think about including prebuilt libfluildsynth.so if we care about MIDI support.

mickael9 commented 6 months ago

libunistring.so.5 is included in the Freedesktop runtime but it isn't used since the RVGL binary requires libunistring.so.2. Perhaps you could update this on your side.

Regarding libfluidsynth, I presume its to allow RVGL to play MIDI files?

Is that actually used by anyone in practice ? I unpacked all the packs in the launcher and not a single one contained a .mid file.

I think you also need to bundle soundfonts for fluidsynth to actually work

Not sure if it's worth it