search

mickelson / attract

A graphical front-end for command line emulators that hides the underlying operating system and is intended to be controlled with a joystick or gamepad.
http://attractmode.org
GNU General Public License v3.0
393 stars 115 forks source link

Layout reload when changing display inconsistent #570

Open zpaolo11x opened 5 years ago

zpaolo11x commented 5 years ago

If a layout changes display using "fe.set_display(n)" the entire layout is reloaded. When the display is changed using the displays menu or the hot keys the layout is not reloaded and only the lists are updated.

I think both approaches are useful: I have a layout where I want to change displays without reloading everything, since the layout is already reactive. But there might be layouts where one wants to reload the layout each time a display is changed.

There should be a way to do all this: of course one can grab signals for next display and prev display and force layout reload, but there's not a way to select a display and not reloading the layout (except with displays menu)

oomek commented 5 years ago

This should be relatively easy to implement by adding a 3rd boolean parameter to reload set_display function set to true as default. Is it that what you need?

zpaolo11x commented 5 years ago

If the boolean will allow to change display without reloading the layout then yes, that's what I'd like to have :)

oomek commented 5 years ago

Yes that's what I'm thinking about. Btw, are you on our Discord server yet? https://discord.gg/NdNkej