search

mickelson / attract

A graphical front-end for command line emulators that hides the underlying operating system and is intended to be controlled with a joystick or gamepad.
http://attractmode.org
GNU General Public License v3.0
393 stars 115 forks source link

Use software decoding for mpeg4 / 2 & vc1 on rpi4 when mmal is used #626

Closed joyrider3774 closed 4 years ago

joyrider3774 commented 4 years ago

fixes #625 by specifying PLATFORM_RPI4=1 when making and not using mmal for mpeg4 / 2 & vc1 as it's not supported on the pi4 .

I explictly did not use a detection for RPI4 as i don't know how and it might break crosscompiling. If people also omit PLATFORM_RPI4=1 on the make line it will just compile as before but breaks mpeg4 / 2 & vc1 videoplay back as it's not supported on pi4.

Also don't know if you would have had me rather changing the USE_MMAL define instead of creating the PLATFORM_RPI4 one but i guess if there are other specifics to RPI4 it could be reused

joyrider3774 commented 4 years ago

i might do a new pr to remove the pr from baseline master i had done as i'm not sure how to fix it in my branch after reseting --hard my fork

joyrider3774 commented 4 years ago

will recommit in another in another branch as i really don't know how to fix this thing