mickelson / attract

A graphical front-end for command line emulators that hides the underlying operating system and is intended to be controlled with a joystick or gamepad.
http://attractmode.org
GNU General Public License v3.0
397 stars 115 forks source link

Snap / video preferences.. #66

Closed checkist84 closed 10 years ago

checkist84 commented 10 years ago

Seems minor issue, but I think it's worth noting it.

Current video/snap selection seems to be done like: 'name video' -> 'name snap' -> 'clone video' -> 'clone snap'

However, some people (including myself) might prefer to have 'name video' -> 'clone video' -> 'name snap' -> 'clone snap'

since videos are rare..

How about adding the option to change this behavior? (something like 'Clone videos are preferred over name snaps'?)

mickelson commented 10 years ago

Good point. My preference is the same as yours when it comes to this and I would rather have the clone video than the named snap.

I think rather than add an option I will just change the rule to work as you describe (unless anyone else feels strongly that the current behaviour should remain)

rogalian commented 10 years ago

Agree that videos should always be preferred. Could we not work in both directions though?

Parent set: name video > clone video > name snap > clone snap Clone set: name video > parent video > clone video > name snap > parent snap > clone snap

This way we try and find the nearest video in all cases before trying the snap.

BENETNATH commented 10 years ago

I personnaly would let the user choose it's behavior. On older computer, you may wanna keep snap before video, to increase the smoothness of the UI during fast scroll. Then load video after a predefined delay.

not sure if i'm clear :) ​

rogalian commented 10 years ago

@BENETNATH That'd be better done in the layout transition code?

BENETNATH commented 10 years ago

dunno, just saying that some user would prefer to have choice , may be this discussion would be better in the forum :)

2014-06-09 11:49 GMT+02:00 rogalian notifications@github.com:

@BENETNATH https://github.com/BENETNATH That'd be better done in the layout transition code?

— Reply to this email directly or view it on GitHub https://github.com/mickelson/attract/issues/66#issuecomment-45475719.

rogalian commented 10 years ago

Layouts can have user configurable options as well ;)

Some snips from mine below. It'd be perfectly reasonable to code in loading the video after a set time in the layout only. The issue discussed is that sometimes a snap will be chosen preferentially instead of a video. It's easy to prefer a snap instead of a video in all cases within the layout code, but it's not possible to prefer a video in all cases:

class UserConfig { </ label="Background Image", help="Choose snap/video snap, title, user image (bg.jpg in layout folder) or no background", options="snap,video,title,user,none" /> bg_image = "video";

// Background Image if ( my_config["bg_image"] == "video") { local bg = fe.add_artwork( "snap", bgx, bgy, bgw, bgh ); } if ( my_config["bg_image"] == "snap") { local bg = fe.add_artwork( "snap", bgx, bgy, bgw, bgh ); bg.movie_enabled = false; } if ( my_config["bg_image"] == "title") { local bg = fe.add_artwork( "title", bgx, bgy, bgw, bgh ); } if ( my_config["bg_image"] == "user") { local bg = fe.add_image( "bg.jpg", 0, 0, fe.layout.width, fe.layout.height); }

BENETNATH commented 10 years ago

ok, got it.

this kind of layout tricks should definitely be added to a demo layout and documented to get the best knowledge shared ^^ ​

mickelson commented 10 years ago

Ok, this should be fixed now!