mickelson
commented
1 year ago That’s great, can you do a pull request with your fix? If not no problem, I can patch this when I get a chanceAndrewOn Jan 30, 2023, at 8:44 AM, spilinek @.***> wrote: Ubuntu 20.04.1 Compiled latest attract code Layout: At-The-Arcade from The Great Themes Collection v10.3.2 Compiled latest attractplus code Layout: At-The-Arcade from The Great Themes Collection Plus Beta 2 attract and attractplus both crash when cycling through games list while using:
Up (Previous Game) Down (Next Game) Previous Page (mapped to PageUp key) Next Page (mapped to PageDown key)
Below are a couple examples of crashes I'm seeing. I think there were other variations of errors reported when the crash happened. double free or corruption (!prev) Aborted (core dumped)
malloc(): corrupted top size Aborted (core dumped)
Compiled the latest version of Valgrind following these instructions
Started attract with valgrind:
~/valgrind/vg-in-place --leak-check=yes ~/latest_attract/attract --loglevel debug 2>&1 | tee ~/latest_attract/log.txt
When using valgrind navigation was very slow in attract. I couldn't reproduce the crash, but I did capture invalid writes. For example:
==30343== Invalid write of size 8
==30343== at 0x67C3C03: ??? (in /usr/lib/x86_64-linux-gnu/libswscale.so.5.9.100)
==30343== by 0x33F0F77F: ???
==30343== by 0xFC713FF: ???
==30343== Address 0x35555200 is 691,200 bytes inside a block of size 691,201 alloc'd
==30343== at 0x484D7E3: memalign (vg_replace_malloc.c:1531)
==30343== by 0x484D94D: posix_memalign (vg_replace_malloc.c:1704)
==30343== by 0x64CF9E4: av_malloc (in /usr/lib/x86_64-linux-gnu/libavutil.so.56.70.100)
==30343== by 0x64CA5C9: av_image_alloc (in /usr/lib/x86_64-linux-gnu/libavutil.so.56.70.100)
==30343== by 0x2C6CF7: FeVideoImp::init_rgba_buffer() (in /home/jeremy/latest_attract/attract)
==30343== by 0x2C8E37: FeMedia::open(std::cxx11::basic_string<char, std::char_traits
This got me looking into FeVideoImp::init_rgba_buffer() in media.cpp. Searched Google for av_image_alloc. I came across this and this where they're using 32 for the align in av_image_alloc. Attract is using 1 for align. I'm not familiar with FFmpeg and couldn't tell what's the difference between 1 and 32 for align.
In media.cpp I located this:
void FeVideoImp::init_rgba_buffer()
{
std::lock_guard
if (rgba_buffer[0])
av_freep(&rgba_buffer[0]);
int ret = av_image_alloc(rgba_buffer, rgba_linesize,
disptex_width, disptex_height,
AV_PIX_FMT_RGBA, 1);
if (ret < 0)
FeLog() << "Error allocating rgba buffer" << std::endl;}
And switched av_image_alloc() align to 32:
void FeVideoImp::init_rgba_buffer()
{
std::lock_guard
if (rgba_buffer[0])
av_freep(&rgba_buffer[0]);
int ret = av_image_alloc(rgba_buffer, rgba_linesize,
disptex_width, disptex_height,
AV_PIX_FMT_RGBA, 32);
// AV_PIX_FMT_RGBA, 1);
if (ret < 0)
FeLog() << "Error allocating rgba buffer" << std::endl;}
With align 32 I'm no longer seeing crashes in attract and attractplus. Ran through valgrind with my fix and I no longer see invalid writes reported.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>
spilinek
Ubuntu 20.04.1
Compiled latest attract code Layout: At-The-Arcade from The Great Themes Collection v10.3.2
Compiled latest attractplus code Layout: At-The-Arcade from The Great Themes Collection Plus Beta 2
attract and attractplus both crash when cycling through games list while using:
Below are a couple examples of crashes I'm seeing. I think there were other variations of errors reported when the crash happened.
Compiled the latest version of Valgrind following these instructions
Started attract with valgrind: ~/valgrind/vg-in-place --leak-check=yes ~/latest_attract/attract --loglevel debug 2>&1 | tee ~/latest_attract/log.txt
While using valgrind, navigation in attract was very slow. I couldn't reproduce the crash, but I did capture invalid writes. For example:
This got me looking into FeVideoImp::init_rgba_buffer() in media.cpp. Searched Google for av_image_alloc. I came across this and this where they're using 32 for the align in av_image_alloc. Attract is using 1 for align. I'm not familiar with FFmpeg and couldn't tell what's the difference between 1 and 32 for align.
In media.cpp I located this:
And switched av_image_alloc() align to 32:
With align 32 I'm no longer seeing crashes in attract and attractplus.
Ran through valgrind with my fix and I no longer see invalid writes reported.